Vladimir Moldovanenko

My feedback

  1. 448 votes
    Sign in
    (thinking…)
    Sign in with: Microsoft
    Signed in as (Sign out)

    We’ll send you updates on this idea

    20 comments  ·  SQL Server » Suggestions  ·  Flag idea as inappropriate…  ·  Admin →

    Upvotes: 72

    <=-=Mar 10 2016 11:26AM=-=>

    It’s a shame that this was submitted as just a “suggestion”. It should actually be listed as a “bug” because there’s only a comparatively small set of use cases where enumeration of the result set of elements is not important.

    <=-=Mar 11 2016 12:47PM=-=>

    I agree that an order column is required; one example use case is where two lists are passed in, and ordinal positions in one list correspond to positions in the other.

    <=-=Mar 11 2016 3:12PM=-=>

    Please see the related suggestion: STRING_SPLIT needs “RemoveEmptyEntries” option, like String.Split in .NET ( https://connect.microsoft.com/SQLServer/feedback/details/2462002/ ).

    <=-=Mar 12 2016 12:02PM=-=>

    This kind of function is primarily needed for de-serializing previously serialized arrays of values of any type format-able as text.
    I therefore recommend to have the result set of this function work excellent with this use-case.

    With de-serialized arrays there is a need to…

    An error occurred while saving the comment
    Vladimir Moldovanenko commented  · 

    Simon, this request is not about performance!
    It's about feature set, about what should have been delivered to begin with, as what was delivered is often useless.
    .NET CLR is not an answer as it does not exist in Azure!
    Happy that it does work for you but there are way more cases, besides trivial, where it does not work.

    An error occurred while saving the comment
    Vladimir Moldovanenko commented  · 

    Chojrak

    Run this

    DECLARE @str nvarchar(100) = N'a,a,b,b,c,d,e'
    SELECT *
    ,ROW_NUMBER()OVER(ORDER BY (SELECT NULL) DESC) Ix
    FROM string_split(@str, N',')

    SELECT *
    ,ROW_NUMBER()OVER(ORDER BY (SELECT NULL) ASC) Ix
    FROM string_split(@str, N',')

    both results are the same, despite ASC/DESC request

    value Ix
    a 1
    a 2
    b 3
    b 4
    c 5
    d 6
    e 7

    What happens to "guarantee" here?
    Is it a bug? Probably not as without explicit way to define ORDER BY there is no guarantee of any ORDER. Results are undefined. At least that is how it is in T-SQL.

    So we do need ordinal index/key

    Therefore, string_split is feature deficient, 1/2 baked. PERIOD!

    Microsoft, do the right thing, add a key/index.

    An error occurred while saving the comment
    Vladimir Moldovanenko commented  · 

    Chojrak, what if one needs ordinal index?
    Guarantee is meaningless without ORDER BY. This is not guarantee, it just happen to work this way, but no guarantee.

    DECLARE @str nvarchar(100) = N'a,a,b,b,c,d,e'
    SELECT *
    ,ROW_NUMBER()OVER(ORDER BY (SELECT NULL)) Ix
    FROM string_split(@str, N',')

    This is what "guarantee" looks for me, when I get key sequence

    SELECT [key], [value]
    FROM OPENJSON(CONCAT('["', REPLACE(@str, ',', '","'), '"]'), '$')

    if I need descending sequence I can build it with explicit guarantee now

    SELECT [key], [value]
    ,ROW_NUMBER()OVER(ORDER BY [key] DESC) Ix
    FROM OPENJSON(CONCAT('["', REPLACE(@str, ',', '","'), '"]'), '$')

    Vladimir Moldovanenko supported this idea  · 
  2. 1 vote
    Sign in
    (thinking…)
    Sign in with: Microsoft
    Signed in as (Sign out)

    We’ll send you updates on this idea

    5 comments  ·  SQL Server » Bugs  ·  Flag idea as inappropriate…  ·  Admin →
    An error occurred while saving the comment
    Vladimir Moldovanenko commented  · 

    Elvis, I tried to reproduce it on SQL Server 2019 (RTM-CU3), using tempdb, comp 150, but it works for me. 'days' is reserved word, does it work(fail) if you change it to something else than 'days'?

  3. 2 votes
    Sign in
    (thinking…)
    Sign in with: Microsoft
    Signed in as (Sign out)

    We’ll send you updates on this idea

    1 comment  ·  SQL Server » Bugs  ·  Flag idea as inappropriate…  ·  Admin →
    An error occurred while saving the comment
    Vladimir Moldovanenko commented  · 

    Reproduced too.
    And it takes 01 minutes and 13 seconds for me, then error

    Vladimir Moldovanenko supported this idea  · 
  4. 747 votes
    Sign in
    (thinking…)
    Sign in with: Microsoft
    Signed in as (Sign out)

    We’ll send you updates on this idea

    89 comments  ·  SQL Server » Suggestions  ·  Flag idea as inappropriate…  ·  Admin →
    Vladimir Moldovanenko supported this idea  · 
  5. 601 votes
    Sign in
    (thinking…)
    Sign in with: Microsoft
    Signed in as (Sign out)

    We’ll send you updates on this idea

    329 comments  ·  SQL Server » Bugs  ·  Flag idea as inappropriate…  ·  Admin →

    Good news (I hope)!

    I was finally able to make progress on this. On the machine with the fix, I was able to open a diagram created by SSMS 17.9.1 (on a different machine). The same diagram opened with 18.3.1 resulted in a crash.

    I’ll do more testing in the next few days and go over all the comments on this page to make sure I capture all the scenarios and make sure they are really fixed.

    It’s looking good, I really hope… :)

    -Matteo

    Vladimir Moldovanenko supported this idea  · 
  6. 1 vote
    Sign in
    (thinking…)
    Sign in with: Microsoft
    Signed in as (Sign out)

    We’ll send you updates on this idea

    0 comments  ·  SQL Server » Bugs  ·  Flag idea as inappropriate…  ·  Admin →
    Vladimir Moldovanenko shared this idea  · 
  7. 2 votes
    Sign in
    (thinking…)
    Sign in with: Microsoft
    Signed in as (Sign out)

    We’ll send you updates on this idea

    2 comments  ·  SQL Server » Bugs  ·  Flag idea as inappropriate…  ·  Admin →
    An error occurred while saving the comment
    Vladimir Moldovanenko commented  · 

    it works in SQL 2019 CUM1 with no change

    An error occurred while saving the comment
    Vladimir Moldovanenko commented  · 

    If you declare it as uniqueidentifier, in SQL 2019, CUM1, it works

    GuidTwo as CAST(GuidOne as uniqueidentifier) PERSISTED

  8. 2 votes
    Sign in
    (thinking…)
    Sign in with: Microsoft
    Signed in as (Sign out)

    We’ll send you updates on this idea

    unplanned  ·  3 comments  ·  SQL Server » Bugs  ·  Flag idea as inappropriate…  ·  Admin →
    An error occurred while saving the comment
    Vladimir Moldovanenko commented  · 

    Also confirmed on Microsoft SQL Server 2019 (RTM-CU1) (KB4527376) - 15.0.4003.23 (X64)

    works with decimals

    SELECT ROUND(CAST(5.175 AS FLOAT),2), ROUND(CAST(5.175 AS decimal(19, 3)),2)

    5.17 5.180

    Vladimir Moldovanenko supported this idea  · 
  9. 3 votes
    Sign in
    (thinking…)
    Sign in with: Microsoft
    Signed in as (Sign out)

    We’ll send you updates on this idea

    0 comments  ·  SQL Server » Bugs  ·  Flag idea as inappropriate…  ·  Admin →
    Vladimir Moldovanenko supported this idea  · 
  10. 2 votes
    Sign in
    (thinking…)
    Sign in with: Microsoft
    Signed in as (Sign out)

    We’ll send you updates on this idea

    0 comments  ·  SQL Server » Bugs  ·  Flag idea as inappropriate…  ·  Admin →
    Vladimir Moldovanenko supported this idea  · 
  11. 4 votes
    Sign in
    (thinking…)
    Sign in with: Microsoft
    Signed in as (Sign out)

    We’ll send you updates on this idea

    1 comment  ·  SQL Server » Bugs  ·  Flag idea as inappropriate…  ·  Admin →
    Vladimir Moldovanenko supported this idea  · 
  12. 125 votes
    Sign in
    (thinking…)
    Sign in with: Microsoft
    Signed in as (Sign out)

    We’ll send you updates on this idea

    31 comments  ·  SQL Server » Suggestions  ·  Flag idea as inappropriate…  ·  Admin →
    Vladimir Moldovanenko supported this idea  · 
  13. 3 votes
    Sign in
    (thinking…)
    Sign in with: Microsoft
    Signed in as (Sign out)

    We’ll send you updates on this idea

    0 comments  ·  SQL Server » Suggestions  ·  Flag idea as inappropriate…  ·  Admin →
    Vladimir Moldovanenko shared this idea  · 
  14. 5 votes
    Sign in
    (thinking…)
    Sign in with: Microsoft
    Signed in as (Sign out)

    We’ll send you updates on this idea

    under review  ·  0 comments  ·  SQL Server » Suggestions  ·  Flag idea as inappropriate…  ·  Admin →
    Vladimir Moldovanenko supported this idea  · 
  15. 2 votes
    Sign in
    (thinking…)
    Sign in with: Microsoft
    Signed in as (Sign out)

    We’ll send you updates on this idea

    0 comments  ·  SQL Server » Suggestions  ·  Flag idea as inappropriate…  ·  Admin →
    Vladimir Moldovanenko supported this idea  · 
  16. 5 votes
    Sign in
    (thinking…)
    Sign in with: Microsoft
    Signed in as (Sign out)

    We’ll send you updates on this idea

    1 comment  ·  SQL Server » Suggestions  ·  Flag idea as inappropriate…  ·  Admin →
    An error occurred while saving the comment
    Vladimir Moldovanenko commented  · 

    Also

    JSON_VALUE(@json, '$.binary', NVARCHAR(MAX))
    or
    JSON_VALUE(@json, '$.binary', varbinary(MAX))

    is needed for large binary base64 encoded binaries. 4000 char limit is really crippling

    Vladimir Moldovanenko supported this idea  · 
  17. 3 votes
    Sign in
    (thinking…)
    Sign in with: Microsoft
    Signed in as (Sign out)

    We’ll send you updates on this idea

    0 comments  ·  SQL Server » Bugs  ·  Flag idea as inappropriate…  ·  Admin →
    Vladimir Moldovanenko supported this idea  · 
  18. 12 votes
    Sign in
    (thinking…)
    Sign in with: Microsoft
    Signed in as (Sign out)

    We’ll send you updates on this idea

    3 comments  ·  SQL Server » Suggestions  ·  Flag idea as inappropriate…  ·  Admin →
    Vladimir Moldovanenko supported this idea  · 
  19. 40 votes
    Sign in
    (thinking…)
    Sign in with: Microsoft
    Signed in as (Sign out)

    We’ll send you updates on this idea

    9 comments  ·  SQL Server » Bugs  ·  Flag idea as inappropriate…  ·  Admin →
    Vladimir Moldovanenko supported this idea  · 
  20. 1 vote
    Sign in
    (thinking…)
    Sign in with: Microsoft
    Signed in as (Sign out)

    We’ll send you updates on this idea

    0 comments  ·  SQL Server » Bugs  ·  Flag idea as inappropriate…  ·  Admin →
    Vladimir Moldovanenko shared this idea  · 
← Previous 1 3 4 5 6

Feedback and Knowledge Base